Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mock functions under MockPciIoProtocol and Create Mock for Smbio, UsbIo and NvmExpressPassthru protocol #1084

Conversation

TsunFeng
Copy link
Contributor

@TsunFeng TsunFeng commented Aug 1, 2024

Description

Add mock functions under MockPciIoProtocol and Create Mock for Smbio, UsbIo and NvmExpressPassthru protocol.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Unit tests component can call these mock functions success

Integration Instructions

N/A

@github-actions github-actions bot added impact:non-functional Does not have a functional impact impact:testing Affects testing labels Aug 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.35%. Comparing base (18ab26a) to head (7fd2228).

Additional details and impacted files
@@               Coverage Diff               @@
##           release/202311    #1084   +/-   ##
===============================================
  Coverage            1.35%    1.35%           
===============================================
  Files                1304     1304           
  Lines              333854   333854           
  Branches             5103     5103           
===============================================
  Hits                 4512     4512           
  Misses             329259   329259           
  Partials               83       83           
Flag Coverage Δ
MdeModulePkg 0.68% <ø> (ø)
MdePkg 5.40% <ø> (ø)
NetworkPkg 0.55% <ø> (ø)
PolicyServicePkg 30.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TsunFeng
Copy link
Contributor Author

TsunFeng commented Aug 1, 2024

Hi @VivianNK, @apop5 and @os-d
Could you help review this change?
Thanks,
TF

@os-d os-d requested a review from VivianNK August 1, 2024 15:25
@TsunFeng TsunFeng force-pushed the personal/TsunFeng/ConsoleMsgLibUT branch from f64653d to f3a7e6f Compare August 2, 2024 02:34
… UsbIo and NvmExpressPassthru protocol

Signed-off-by: TsunFeng <v-tshuang@microsoft.com>
@VivianNK VivianNK force-pushed the personal/TsunFeng/ConsoleMsgLibUT branch from f3a7e6f to 7fd2228 Compare August 2, 2024 17:22
@VivianNK VivianNK enabled auto-merge (rebase) August 2, 2024 17:23
@VivianNK VivianNK merged commit 4790eff into microsoft:release/202311 Aug 2, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact impact:testing Affects testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants